Add manual, skip, and fork-review controls #19

Open
opened 2026-07-14 22:32:24 -04:00 by caleb-brown · 0 comments
Owner

What to build

Authorized maintainers can control review behavior from Forgejo using explicit commands and labels, while untrusted contributors cannot spend review budget or authorize later fork revisions.

Acceptance criteria

  • The documented manual review and rerun commands create intentional work for the current revision.
  • Skip pauses automatic review according to policy while leaving authorized explicit review available.
  • Profile-selection controls affect the intended request without silently selecting an invalid profile.
  • Authorization is checked live through Forgejo permissions rather than trusting webhook payload role fields.
  • Fork pull requests never auto-review and require explicit maintainer authorization for each exact head SHA.
  • An authorization attached to an older fork revision cannot authorize a later push.
  • Tests cover authorized, unauthorized, stale-authorization, malformed-command, skip, and profile-selection scenarios.

Blocked by

  • #12 — Install a repository and prove webhook delivery
  • #18 — Keep feedback correct across retries and revisions
## What to build Authorized maintainers can control review behavior from Forgejo using explicit commands and labels, while untrusted contributors cannot spend review budget or authorize later fork revisions. ## Acceptance criteria - [ ] The documented manual review and rerun commands create intentional work for the current revision. - [ ] Skip pauses automatic review according to policy while leaving authorized explicit review available. - [ ] Profile-selection controls affect the intended request without silently selecting an invalid profile. - [ ] Authorization is checked live through Forgejo permissions rather than trusting webhook payload role fields. - [ ] Fork pull requests never auto-review and require explicit maintainer authorization for each exact head SHA. - [ ] An authorization attached to an older fork revision cannot authorize a later push. - [ ] Tests cover authorized, unauthorized, stale-authorization, malformed-command, skip, and profile-selection scenarios. ## Blocked by - [#12](https://git.caleb-brown.dev/caleb-brown/temper/issues/12) — Install a repository and prove webhook delivery - [#18](https://git.caleb-brown.dev/caleb-brown/temper/issues/18) — Keep feedback correct across retries and revisions
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
caleb-brown/temper#19
No description provided.